golang http fitler: fix race when waiting callback from Envoy #32081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: doujiang24 <[email protected]>
spacewander
approved these changes
Jan 29, 2024
|
it's good to merge, thanks @jmarantz |
jmarantz
approved these changes
Jan 30, 2024
spacewander
pushed a commit
to mosn/envoy
that referenced
this pull request
Jun 27, 2024
…roxy#32081) fix envoyproxy#31654 and envoyproxy#29496 Thanks @spacewander for founding this race: envoyGoRequestSemaDec may be invoked eariler than r.sema.Wait, then, there is no one to resume the r.sema.Wait. Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: Fixes: envoyproxy#31654, envoyproxy#29496 Signed-off-by: doujiang24 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #31654 and #29496
Thanks @spacewander for founding this race:
envoyGoRequestSemaDecmay be invoked eariler thanr.sema.Wait, then, there is no one to resume ther.sema.Wait.Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]