Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.29] google_grpc: add a runtime flag to disable TLSv1.3 #32532

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

kyessenov
Copy link
Contributor

Backport of #32315

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <[email protected]>
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #32532 was opened by kyessenov.

see: more, trace.

@kyessenov kyessenov requested a review from phlax February 23, 2024 00:10
Change-Id: I5b5ec42d5b3138060505c74d313d759199083e8d
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov kyessenov changed the title google_grpc: add a runtime flag to disable TLSv1.3 [1.29] google_grpc: add a runtime flag to disable TLSv1.3 Feb 23, 2024
@phlax phlax merged commit 47766f0 into envoyproxy:release/v1.29 Feb 23, 2024
41 checks passed
kyessenov added a commit to kyessenov/envoy that referenced this pull request Feb 23, 2024
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <[email protected]>
kyessenov added a commit to kyessenov/envoy that referenced this pull request Feb 23, 2024
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <[email protected]>
kyessenov added a commit to kyessenov/envoy that referenced this pull request Feb 23, 2024
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <[email protected]>
briansonnenberg pushed a commit to briansonnenberg/envoy that referenced this pull request Mar 4, 2024
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <[email protected]>
phlax pushed a commit that referenced this pull request Mar 4, 2024
* google_grpc: add a runtime flag to disable TLSv1.3 (#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <[email protected]>
phlax pushed a commit that referenced this pull request Mar 4, 2024
* google_grpc: add a runtime flag to disable TLSv1.3 (#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <[email protected]>
phlax pushed a commit that referenced this pull request Mar 5, 2024
* google_grpc: add a runtime flag to disable TLSv1.3 (#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <[email protected]>
SeanKilleen pushed a commit to SeanKilleen/envoy that referenced this pull request Apr 3, 2024
* google_grpc: add a runtime flag to disable TLSv1.3 (envoyproxy#32315)

Change-Id: Id88723a81d4b1586bf12be6f4dc7a81ae7b0d9c4

Commit Message: Adds a temporary runtime flag to disable TLSv1.3 by gRPC SDK until a proper xDS extension can be added.
Additional Description:
Risk Level: low, default false
Testing: regression

Change-Id: I34daae55ede7c8093b0dac1fa6ff5a5dc8df677d
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Sean Killeen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants