Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC: Implement max_receive_message_length in envoy gRPC #32711

Merged
merged 21 commits into from
Apr 4, 2024

fix

ebfc99c
Select commit
Loading
Failed to load commit list.
Merged

gRPC: Implement max_receive_message_length in envoy gRPC #32711

fix
ebfc99c
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Core succeeded Mar 29, 2024 in 3m 39s

Mobile/Core (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/Core (pr/32711/main@ebfc99c)

Check started by

Request (pr/32711/main@ebfc99c)

tyxia @tyxia ebfc99c #32711 merge main@77458ea

gRPC: Implement max_receive_message_length in envoy gRPC

Over-frame-limit error can now be surfaced from gRPC codec level after PR #32511

Envoy gRPC client can leverage this to implement max_recevie_meassage_length with config field. This field is defaulted to 0, which means no limits.

  • When the message is over limit, it can be rejected before frame data is fully decoded (i.e. expanded).
  • This can prevent malicious attack , for example, unbounded and huge message is sent over channel and is injected and buffered in Envoy over Envoy-gRPC.

error status will be improved by #32676

Environment

Request variables

Key Value
ref 5990e68d16cf2d77e6b03bad1a759116ae61d4e8
sha ebfc99c
pr 32711
base-sha 77458ea
actor tyxia @tyxia
message gRPC: Implement max_receive_message_length in envoy gRPC...
started 1711730283.482049
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 30
patch 0
dev true