Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptomb: reduce memory copy in ECDSA #33201

Merged
merged 5 commits into from
Apr 1, 2024

cryptomb: avoid speed test on arm

068f576
Select commit
Loading
Failed to load commit list.
Merged

cryptomb: reduce memory copy in ECDSA #33201

cryptomb: avoid speed test on arm
068f576
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Perf skipped Mar 29, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/33201/main@068f576)

zhxie @zhxie 068f576 #33201 merge main@d6a696d

cryptomb: reduce memory copy in ECDSA

Signed-off-by: Xie Zhihao [email protected]

Commit Message: cryptomb: reduce memory copy in ECDSA
Additional Description:

The original implementation serializes signatures into a temporary output buffer during processing phase and then copy to the BoringSSL buffer in the completion phase. This patch change the way and directly serializes signatures to the BoringSSL buffer.

In addition, the patch adds a speed test to track the performance change by mathematical implementation of private key provider.

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: Requires AVX512 or equivalent CPU instruction set

Environment

Request variables

Key Value
ref 137962d13b869973e019707f53043b633dfb0206
sha 068f576
pr 33201
base-sha d6a696d
actor zhxie @zhxie
message cryptomb: reduce memory copy in ECDSA...
started 1711695364.460553
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 30
patch 0
dev true