-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang filter: do not clear route cache in ·HeaderMap.Set` by default. #33229
Conversation
introduce a new API `ClearRouteCache` to clear route cache. fix envoyproxy#33082 Signed-off-by: doujiang24 <[email protected]>
/assign @wangfakang @spacewander |
@spacewander cannot be assigned to this issue. |
@doujiang24 I CCed few owner, but let me know if you think this is ready to merge, I can help to merge since this is contrib ext. |
Thanks, @soulxu , let's wait an approval from from @wangfakang @spacewander . |
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks your work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
envoyproxy#33229) * golang filter: do not clear route cache in HeaderMap.Set by default. introduce a new API `ClearRouteCache` to clear route cache. fix envoyproxy#33082 Signed-off-by: doujiang24 <[email protected]>
envoyproxy#33229) * golang filter: do not clear route cache in HeaderMap.Set by default. introduce a new API `ClearRouteCache` to clear route cache. fix envoyproxy#33082 Signed-off-by: doujiang24 <[email protected]>
introduce a new API
ClearRouteCache
to clear route cache.fix #33082
Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]