Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing upstream string formatters #33857

Merged

Merge branch 'main' into stringformat/upstream-peer-uri-san

62e8a3f
Select commit
Loading
Failed to load commit list.
Merged

Add missing upstream string formatters #33857

Merge branch 'main' into stringformat/upstream-peer-uri-san
62e8a3f
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/TSAN skipped May 23, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/33857/main@62e8a3f)

keithmattix @keithmattix 62e8a3f #33857 merge main@838bc86

Add missing upstream string formatters

%UPSTREAM_{PEER,LOCAL}_{URI,DNS,IP}_SAN% were not implemented; add them. Given that we're not too far from when v1.30 was cut, would it be possible to backport this to 1.30?

Environment

Request variables

Key Value
ref 3d0adae
sha 62e8a3f
pr 33857
base-sha 838bc86
actor keithmattix @keithmattix
message Add missing upstream string formatters...
started 1716496425.442939
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true