tls_inspector: Fix invalid ALPN extension in test #34300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit stops generateClientHelloFromJA3Fingerprint() generating client hellos containing an invalid ALPN extension. It also updates relevant tls_inspector_test functions to check the ALPN value, if expected. When the generateClientHelloFromJA3Fingerprint() function was asked to include an ALPN extension (16) in the generated client hello, it was generating a default empty extension with the correct id (16) but a zero length. While this is technically a valid extension, it is not a valid ALPN extension, which must include a list of the client's preferred protocol(s). This was causing test failures in the envoy-openssl repo because OpenSSL responds to the malformed ALPN extension by sending a TLS alert 50 (Decode Error) which causes many of the tls_inspector_test functions to fail. Signed-off-by: Ted Poole <[email protected]>
ggreenway
approved these changes
May 22, 2024
tedjpoole
added a commit
to tedjpoole/envoyproxy-envoy
that referenced
this pull request
May 22, 2024
This commit stops generateClientHelloFromJA3Fingerprint() generating client hellos containing an invalid ALPN extension. It also updates relevant tls_inspector_test functions to check the ALPN value, if expected. When the generateClientHelloFromJA3Fingerprint() function was asked to include an ALPN extension (16) in the generated client hello, it was generating a default empty extension with the correct id (16) but a zero length. While this is technically a valid extension, it is not a valid ALPN extension, which must include a list of the client's preferred protocol(s). This was causing test failures in the envoy-openssl repo because OpenSSL responds to the malformed ALPN extension by sending a TLS alert 50 (Decode Error) which causes many of the tls_inspector_test functions to fail. Signed-off-by: Ted Poole <[email protected]>
tedjpoole
added a commit
to tedjpoole/envoyproxy-envoy
that referenced
this pull request
May 22, 2024
This commit stops generateClientHelloFromJA3Fingerprint() generating client hellos containing an invalid ALPN extension. It also updates relevant tls_inspector_test functions to check the ALPN value, if expected. When the generateClientHelloFromJA3Fingerprint() function was asked to include an ALPN extension (16) in the generated client hello, it was generating a default empty extension with the correct id (16) but a zero length. While this is technically a valid extension, it is not a valid ALPN extension, which must include a list of the client's preferred protocol(s). This was causing test failures in the envoy-openssl repo because OpenSSL responds to the malformed ALPN extension by sending a TLS alert 50 (Decode Error) which causes many of the tls_inspector_test functions to fail. Signed-off-by: Ted Poole <[email protected]>
phlax
pushed a commit
that referenced
this pull request
May 22, 2024
This commit stops generateClientHelloFromJA3Fingerprint() generating client hellos containing an invalid ALPN extension. It also updates relevant tls_inspector_test functions to check the ALPN value, if expected. When the generateClientHelloFromJA3Fingerprint() function was asked to include an ALPN extension (16) in the generated client hello, it was generating a default empty extension with the correct id (16) but a zero length. While this is technically a valid extension, it is not a valid ALPN extension, which must include a list of the client's preferred protocol(s). This was causing test failures in the envoy-openssl repo because OpenSSL responds to the malformed ALPN extension by sending a TLS alert 50 (Decode Error) which causes many of the tls_inspector_test functions to fail. Signed-off-by: Ted Poole <[email protected]>
ggreenway
pushed a commit
that referenced
this pull request
May 22, 2024
…4300) (#34302) tls_inspector: Fix invalid ALPN extension in test (#34300) This commit stops generateClientHelloFromJA3Fingerprint() generating client hellos containing an invalid ALPN extension. It also updates relevant tls_inspector_test functions to check the ALPN value, if expected. When the generateClientHelloFromJA3Fingerprint() function was asked to include an ALPN extension (16) in the generated client hello, it was generating a default empty extension with the correct id (16) but a zero length. While this is technically a valid extension, it is not a valid ALPN extension, which must include a list of the client's preferred protocol(s). This was causing test failures in the envoy-openssl repo because OpenSSL responds to the malformed ALPN extension by sending a TLS alert 50 (Decode Error) which causes many of the tls_inspector_test functions to fail. Signed-off-by: Ted Poole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit stops
generateClientHelloFromJA3Fingerprint()generating client hellos containing an invalid ALPN extension. It also updates relevanttls_inspector_testfunctions to check the ALPN value, if expected.When the
generateClientHelloFromJA3Fingerprint()function was asked to include an ALPN extension (16) in the generated client hello, it was generating a default empty extension with the correct id (16) but a zero length. While this is technically a valid extension, it is not a valid ALPN extension, which must include a list of the client's preferred protocol(s).This was causing test failures in the
envoyproxy/envoy-opensslrepo because OpenSSL responds to the malformed ALPN extension by sending a TLS alert 50 (Decode Error) which causes many of thetls_inspector_testfunctions to fail.Risk Level: Low
Testing: Modifies existing tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A