-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple formats of ORCA headers. #35894
Conversation
I will insist on my previous point: use as less as possible header to do this work. The But for new format, we can use same header to carry content with different format. And single prefix in the header value could be used to indicate it's format. like:
/wait |
Ran some benchmarking tests to investigate performance questions raised in original PR an got the following:
|
cc @blake-snyder Hi, per our offline discussion, I think the final conclusion is keep only one header and only to support on format first, but will add a short prefix flag ('TEXT ' or 'T ', a single space is used to separate the prefix and value) in the header value. It's easy to add prefix flag in the future in the code, but it's not easy to keep backward compatibility in the future if no this flag now. This is the reason why we discuss this for a long time. And CI is complaining, you may need to check it. /wait |
And I have to say sorry, this is not a big job, but finally it taken your very long time. But I actually don't want to compromise on this point. :( Because I know if I compromised this time, then in the future, in case new format is necessary, the new header must be introduced. |
Signed-off-by: blake-snyder <[email protected]>
Signed-off-by: blake-snyder <[email protected]>
Signed-off-by: blake-snyder <[email protected]>
/retest |
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: blake-snyder <[email protected]>
Thanks so much for this great contribution and all your patience. |
Commit Message: Add support for multiple formats of ORCA headers. Additional Description: Add support for multiple formats of ORCA headers. ORCA parsing introduced in envoyproxy#35422 [Original Design Proposal](envoyproxy#6614) [Using ORCA load reports in Envoy](https://docs.google.com/document/d/1gb_2pcNnEzTgo1EJ6w1Ol7O-EH-O_Ysu5o215N9MTAg/edit#heading=h.bi4e79pb39fe) Risk Level: Low Testing: See included unit tests. Docs Changes: N/A Release Notes: N/A Platform Specific Features: JSON format unsupported on Mobile. CC @efimki @adisuissa @wbpcode --------- Signed-off-by: blake-snyder <[email protected]> Signed-off-by: Steven Jin Xuan <[email protected]>
Commit Message: Add support for multiple formats of ORCA headers.
Additional Description: Add support for multiple formats of ORCA headers. ORCA parsing introduced in #35422
Original Design Proposal
Using ORCA load reports in Envoy
Risk Level: Low
Testing: See included unit tests.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: JSON format unsupported on Mobile.
CC @efimki @adisuissa @wbpcode