Updated RLQS Response handling to not reset TokenBucket state #36478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hasn't actually changed its config, otherwise token state will always reset Signed-off-by: Brian Surber <[email protected]>
… case's handling to be consistent across all actions Signed-off-by: Brian Surber <[email protected]>
tyxia
reviewed
Oct 8, 2024
| @@ -77,6 +77,20 @@ void RateLimitClientImpl::sendUsageReport(absl::optional<size_t> bucket_id) { | |||
| stream_->sendMessage(buildReport(bucket_id), /*end_stream=*/false); | |||
| } | |||
|
|
|||
| bool cacheHasTokenBucket(const ::envoy::type::v3::TokenBucket& token_bucket, | |||
There was a problem hiding this comment.
This function is not used. Remove?
|
/wait |
Signed-off-by: Brian Surber <[email protected]>
anitabyte
pushed a commit
to anitabyte/envoy
that referenced
this pull request
Oct 9, 2024
…nvoyproxy#36478) Commit Message: When an RLQS response comes in that would create a duplicate TokenBucket (because the underlying config hasn't changed), treat this as a refresh to the TTL but don't reset the TokenBucket's state by recreating it. Additional Description: Risk Level: Low Testing: Unit testing Docs Changes: Release Notes: Platform Specific Features: --------- Signed-off-by: Brian Surber <[email protected]> Signed-off-by: anitabyte <[email protected]>
Stevenjin8
pushed a commit
to Stevenjin8/envoy
that referenced
this pull request
Oct 10, 2024
…nvoyproxy#36478) Commit Message: When an RLQS response comes in that would create a duplicate TokenBucket (because the underlying config hasn't changed), treat this as a refresh to the TTL but don't reset the TokenBucket's state by recreating it. Additional Description: Risk Level: Low Testing: Unit testing Docs Changes: Release Notes: Platform Specific Features: --------- Signed-off-by: Brian Surber <[email protected]> Signed-off-by: Steven Jin Xuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: When an RLQS response comes in that would create a duplicate TokenBucket (because the underlying config hasn't changed), treat this as a refresh to the TTL but don't reset the TokenBucket's state by recreating it.
Additional Description:
Risk Level: Low
Testing: Unit testing
Docs Changes:
Release Notes:
Platform Specific Features: