[mobile]expose onNetworkTypeChanged API to Engine #36504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Renjie Tang <[email protected]>
RenjieTang
requested review from
RyanTheOptimist,
alyssawilk,
abeyad and
fredyw
as code owners
fredyw
approved these changes
Oct 8, 2024
abeyad
approved these changes
Oct 8, 2024
|
/retest |
Stevenjin8
pushed a commit
to Stevenjin8/envoy
that referenced
this pull request
Oct 10, 2024
Commit Message: expose onNetworkTypeChanged API to Engine Additional Description: This prevents applications from directly depending on InternalEngine. Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Platform Specific Features: mobile only Signed-off-by: Renjie Tang <[email protected]> Signed-off-by: Steven Jin Xuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: expose onNetworkTypeChanged API to Engine
Additional Description: This prevents applications from directly depending on InternalEngine.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile only