Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance comment about MonotonicTime #8011

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Enhance comment about MonotonicTime #8011

merged 1 commit into from
Aug 23, 2019

Commits on Aug 22, 2019

  1. Enhance comment about MonotonicTime 

    Depending on the execution environment in which envoy is being run, it
is possible that some of the assumption on the clock are maybe not
holding as previously commented. With some sandboxing technologies the
clock does not reference the machine boot time but the sandbox boot
time. This invalidates the assumtpion that the first update in the
cluster_manager will most likely fall out of the windows and ends up
showing a non intuitive behavior difficult to catch.
This PR simply adds a comment that will allow the reader to consider
this option while reading to the code.

Signed-off-by: Flavio Crisciani <[email protected]>
    @fcrisciani
    fcrisciani committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    df142de View commit details
    Browse the repository at this point in the history