Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upstream: delete stale TODO #8028

Merged
merged 1 commit into from
Aug 23, 2019
Merged

upstream: delete stale TODO #8028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions source/common/upstream/upstream_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,12 +1311,6 @@ bool BaseDynamicClusterImpl::updateDynamicHostList(const HostVector& new_hosts,

// At this point we've accounted for all the new hosts as well the hosts that previously
// existed in this priority.

// TODO(mattklein123): This stat is used by both the RR and LR load balancer to decide at
// runtime whether to use either the weighted or unweighted mode. If we extend weights to
// static clusters or DNS SRV clusters we need to make sure this gets set. Better, we should
// avoid pivoting on this entirely and probably just force a host set refresh if any weights
// change.
info_->stats().max_host_weight_.set(max_host_weight);

// Whatever remains in current_priority_hosts should be removed.
Expand Down