Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding debug hints for integration test config failures #8038

Merged
merged 2 commits into from
Aug 26, 2019
Merged

test: adding debug hints for integration test config failures #8038

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4f39d5
test: adding debug hints
alyssawilk Aug 26, 2019
246be91
fixup
alyssawilk Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions test/extensions/filters/http/cors/cors_filter_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@ class CorsFilterIntegrationTest : public testing::TestWithParam<Network::Address
auto* route = virtual_host->add_routes();
route->mutable_match()->set_prefix("/no-cors");
route->mutable_route()->set_cluster("cluster_0");
route->mutable_route()
->mutable_cors()
->mutable_filter_enabled()
->mutable_default_value()
->set_numerator(0);
route->mutable_route()->mutable_cors()->mutable_enabled()->set_value(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change?

}

{
Expand Down
3 changes: 2 additions & 1 deletion test/integration/integration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,8 @@ void BaseIntegrationTest::createGeneratedApiTestServer(const std::string& bootst
if (!allow_lds_rejection) {
RELEASE_ASSERT(test_server_->counter(rejected) == nullptr ||
test_server_->counter(rejected)->value() == 0,
"Lds update failed");
"Lds update failed. For details, run test with -l trace and look for "
"\"Error adding/updating listener(s)\" in the logs.");
}
time_system_.sleep(std::chrono::milliseconds(10));
}
Expand Down