Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: clone v2[alpha] to v3alpha. #8125

Merged
merged 2 commits into from
Sep 3, 2019
Merged

api: clone v2[alpha] to v3alpha. #8125

merged 2 commits into from
Sep 3, 2019

Commits on Sep 3, 2019

  1. api: clone v2[alpha] to v3alpha. 

    This patch establishes a v3alpha baseline API, by doing a simple copy of
v2[alpha] dirs and some sed-style heuristic fixups of BUILD dependencies
and proto package namespaces.

The objective is provide a baseline which we can compare the output from
tooling described in envoyproxy#8083 in later PRs, providing smaller visual diffs.

The core philosophy of the API migration is that every step will be
captured in a script (at least until the last manual steps),
api/migration/v3alpha.sh. This script will capture deterministic
migration steps, allowing v2[alpha] to continue to be updated until we
finalize v3.

There is likely to be significant changes, e.g. in addition to the work
scoped for v3, we might want to reduce the amount of API churn by
referring back to v2 protos where it makes sense. This will be done via
tooling in later PRs.

Part of envoyproxy#8083.

Risk level: Low
Testing: build @envoy_api//...

Signed-off-by: Harvey Tuch <[email protected]>
    @htuch
    htuch committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    5c9cca4 View commit details
    Browse the repository at this point in the history

  2. Clarifications. 

    Signed-off-by: Harvey Tuch <[email protected]>
    @htuch
    htuch committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    264e618 View commit details
    Browse the repository at this point in the history