Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http filter: ALPN http filter to override ALPN for upstream connection #8498

Closed
wants to merge 5 commits into from

Conversation

yxue
Copy link
Contributor

@yxue yxue commented Oct 4, 2019

Signed-off-by: crazyxy [email protected]

Description: Add ALPN http filter to override ALPN for upstream connection
Risk Level: Low
Testing: Unit test
Docs Changes: https://github.com/envoyproxy/envoy/compare/master...yxue:alpn?expand=1#diff-34da83bdc37c06f88007d918bfb6890d
Release Notes: https://github.com/envoyproxy/envoy/compare/master...yxue:alpn?expand=1#diff-d8d3e33358b55e6c0466dd1bb5f40c79
Fixes #Issue: Fix #8197

Signed-off-by: crazyxy <[email protected]>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #8498 was opened by yxue.

see: more, trace.

Signed-off-by: crazyxy <[email protected]>
Signed-off-by: crazyxy <[email protected]>
Signed-off-by: crazyxy <[email protected]>
@lizan
Copy link
Member

lizan commented Oct 4, 2019

at high level I doubt anyone outside istio will use this, thoughts @envoyproxy/maintainers?

Signed-off-by: crazyxy <[email protected]>
@mattklein123
Copy link
Member

+1, let's skip merging this to upstream until someone else asks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow specify application protocol in cluster upstream transport socket
4 participants