udp_proxy: scaffolding #8883
Merged
udp_proxy: scaffolding #8883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first commit in a series to support UDP proxying. There are quite a few TODOs in the code before this feature will be considered a MVP. Part of #492 Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Matt Klein <[email protected]>
goaway
reviewed
Nov 7, 2019
goaway
reviewed
Nov 7, 2019
mattklein123
commented
Nov 7, 2019
mattklein123
commented
Nov 7, 2019
goaway
previously approved these changes
Nov 7, 2019
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
danzh2010
reviewed
Nov 8, 2019
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
|
@danzh2010 updated per comments |
|
/retest |
|
🔨 rebuilding |
danzh2010
reviewed
Nov 11, 2019
danzh2010
previously approved these changes
Nov 11, 2019
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
htuch
approved these changes
Nov 11, 2019
htuch
reviewed
Nov 20, 2019
| ENVOY_LOG_MISC( | ||
| debug, "Kernel dropped {} more packets. Consider increase receive buffer size.", delta); | ||
| } | ||
| } while (true); |
There was a problem hiding this comment.
@mattklein123 this loop runs until we run out of packets; do you think we should have some bound on the loop to ensure fairness across epoll events? This may be a possible DoS vector once UDP becomes a thing.
There was a problem hiding this comment.
Yes @danzh2010 and I have already discussed thi and there are various TODOs in the code. Someone will be doing this as a follow up once the main support for UDP and QUIC merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first commit in a series to support UDP proxying.
There are quite a few TODOs in the code before this feature
will be considered a MVP.
Part of #492
Risk Level: Low (some changes to core UDP processing code
which is not heavily used)
Testing: Integration test
Docs Changes: N/A
Release Notes: N/A