Fix compilation in http_integration.cc #8896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes -Werror=maybe-uninitialized Risk Level: Low Testing: yes Docs Changes: n/a Release Notes: n/a Fixes envoyproxy#8894 Signed-off-by: Anatoly Scheglov <[email protected]>
ascheglov
commented
Nov 5, 2019
| @@ -422,6 +422,7 @@ TEST_P(DownstreamProtocolIntegrationTest, RetryHostPredicateFilter) { | |||
|
|
|||
| // Note how we're expecting each upstream request to hit the same upstream. | |||
| auto upstream_idx = waitForNextUpstreamRequest({0, 1}); | |||
| ASSERT_LT(upstream_idx, fake_upstreams_.size()); | |||
There was a problem hiding this comment.
That's the only place where the return value was used.
There was a problem hiding this comment.
Instead can you have it return an absl::optional? That is more future proof IMO.
mattklein123
requested changes
Nov 6, 2019
| @@ -422,6 +422,7 @@ TEST_P(DownstreamProtocolIntegrationTest, RetryHostPredicateFilter) { | |||
|
|
|||
| // Note how we're expecting each upstream request to hit the same upstream. | |||
| auto upstream_idx = waitForNextUpstreamRequest({0, 1}); | |||
| ASSERT_LT(upstream_idx, fake_upstreams_.size()); | |||
There was a problem hiding this comment.
Instead can you have it return an absl::optional? That is more future proof IMO.
Signed-off-by: Anatoly Scheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes -Werror=maybe-uninitialized
Risk Level: Low
Testing: yes
Docs Changes: n/a
Release Notes: n/a
Fixes #8894