udp proxy: complete MVP #9046
Merged
udp proxy: complete MVP #9046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This is stacked on top of #8999. I wanted to get this out before I take off for conference week in case anyone wants to kick the tires. cc @danzh2010 |
moderation
reviewed
Nov 16, 2019
|
Quick note here for anyone trying this out that I forgot to mention. Until we merge the SO_REUSEPORT change for UDP listeners, this will only work with concurrency == 1. |
moderation
reviewed
Nov 18, 2019
Fixes #492 Signed-off-by: Matt Klein <[email protected]>
mattklein123
force-pushed
the
final_udp_change
branch
from
8524995
to
29b8d84
Compare
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
|
@danzh2010 @moderation ready for proper review. Thank you! |
moderation
reviewed
Nov 25, 2019
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
|
Note that I just pushed a fix for the test flake reported in #9018 to this PR. It's low frequency enough that I think we can land here. |
danzh2010
reviewed
Dec 2, 2019
danzh2010
reviewed
Dec 3, 2019
| @@ -569,7 +569,8 @@ class FakeUpstream : Logger::Loggable<Logger::Id::testing>, | |||
| std::chrono::milliseconds timeout = TestUtility::DefaultTimeout); | |||
|
|
|||
| // Send a UDP datagram on the fake upstream thread. | |||
| void sendUdpDatagram(const std::string& buffer, const Network::Address::Instance& peer); | |||
| void sendUdpDatagram(const std::string& buffer, | |||
There was a problem hiding this comment.
This is the fix for #9018
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
|
@danzh2010 updated PTAL |
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danzh2010
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492
Fixes #9018
Risk Level: Low, new feature
Testing: Integration/unit
Docs Changes: Added
Release Notes: Added