reduce readinessProbe failureThreshold and periodSeconds #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reduces time for the endpoint to be removed from the endpointSlice from `30s` (3 * 10) to `5s` (1 * 5) * Since kube-proxy and CNIs rely on this info and so do external LBs like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer Signed-off-by: Arko Dasgupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4021 +/- ##
==========================================
- Coverage 67.59% 67.58% -0.02%
==========================================
Files 185 185
Lines 22591 22591
==========================================
- Hits 15271 15267 -4
- Misses 6227 6229 +2
- Partials 1093 1095 +2 ☔ View full report in Codecov by Sentry. |
zirain
approved these changes
Aug 9, 2024
cnvergence
approved these changes
Aug 9, 2024
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Sep 7, 2024
…4021) * Reduces time for the endpoint to be removed from the endpointSlice from `30s` (3 * 10) to `5s` (1 * 5) * Since kube-proxy and CNIs rely on this info and so do external LBs like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 67575b8) Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Sep 7, 2024
…4021) * Reduces time for the endpoint to be removed from the endpointSlice from `30s` (3 * 10) to `5s` (1 * 5) * Since kube-proxy and CNIs rely on this info and so do external LBs like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 67575b8) Signed-off-by: Arko Dasgupta <[email protected]>
guydc
pushed a commit
that referenced
this pull request
Sep 10, 2024
* bugfix: fix upstream get unwanted /. (#3990) * bugfix: fix upstream get unwanted /. Signed-off-by: qicz <[email protected]> * ut for bugfix Signed-off-by: qicz <[email protected]> --------- Signed-off-by: qicz <[email protected]> Co-authored-by: Xunzhuo <[email protected]> (cherry picked from commit b77f6a4) Signed-off-by: Arko Dasgupta <[email protected]> * feat: gateway http listener isolation (#4000) Signed-off-by: Kobi Levi <[email protected]> (cherry picked from commit 97830e9) Signed-off-by: Arko Dasgupta <[email protected]> * fix: multiple reference grants in same namespace (#4008) * fix: multiple reference grants in same namespace Signed-off-by: Ardika Bagus <[email protected]> * test: add e2e test Signed-off-by: Ardika Bagus <[email protected]> * chore: wrong service port Signed-off-by: Ardika Bagus <[email protected]> --------- Signed-off-by: Ardika Bagus <[email protected]> (cherry picked from commit b82f4b2) Signed-off-by: Arko Dasgupta <[email protected]> * reduce readinessProbe failureThreshold and periodSeconds (#4021) * Reduces time for the endpoint to be removed from the endpointSlice from `30s` (3 * 10) to `5s` (1 * 5) * Since kube-proxy and CNIs rely on this info and so do external LBs like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 67575b8) Signed-off-by: Arko Dasgupta <[email protected]> * fix: add header values as described in the documentation (#4031) Add header values after splitting the provided value string on ',', like described in the documentation. Signed-off-by: Lior Okman <[email protected]> (cherry picked from commit eac30d6) Signed-off-by: Arko Dasgupta <[email protected]> * fix ratelimit statsd not working (#4073) fix ratelimit statd not working Signed-off-by: zirain <[email protected]> (cherry picked from commit 6ab6482) Signed-off-by: Arko Dasgupta <[email protected]> * fix: active http healthcheck documents a default for expected status, but doesn't use it (#4090) If no expected status was explicitly set, use the default value as described in the documentation. Signed-off-by: Lior Okman <[email protected]> (cherry picked from commit 0926b38) Signed-off-by: Arko Dasgupta <[email protected]> * Fix IsNotFound check for secret and configmap (#4126) fix IsNotFound check for secret and configmap Signed-off-by: TasdidurRahman <[email protected]> (cherry picked from commit c20315f) Signed-off-by: Arko Dasgupta <[email protected]> * fix: assign sugar logger name. (#4144) Signed-off-by: qicz <[email protected]> Co-authored-by: zirain <[email protected]> (cherry picked from commit b50f5fa) Signed-off-by: Arko Dasgupta <[email protected]> * use sets and return stable result (#4074) Signed-off-by: zirain <[email protected]> (cherry picked from commit 6066f5a) Signed-off-by: Arko Dasgupta <[email protected]> * delete internal/gatewayapi/clustersettings.go NA for v1.1 Signed-off-by: Arko Dasgupta <[email protected]> * bump to go1.22.7 (#4175) * bump to go1.22.6 Signed-off-by: zirain <[email protected]> * bump to 1.22.7 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 69bf882) Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: qicz <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Kobi Levi <[email protected]> Signed-off-by: Ardika Bagus <[email protected]> Signed-off-by: Lior Okman <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: TasdidurRahman <[email protected]> Co-authored-by: qi <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Co-authored-by: Kobi Levi <[email protected]> Co-authored-by: Ardika <[email protected]> Co-authored-by: Lior Okman <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Tasdidur Rahman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces time for the endpoint to be removed from the endpointSlice from
30s(3 * 10) to5s(1 * 5)Since kube-proxy and CNIs rely on this info and so do external LBs like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer
The default drain time is
30swhich was also equal to the max time for readinessProbe to failRelates to #4002