api: support setting trusted CIDRs #4500
Open
+137
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudrakhp
force-pushed
the
xff_trusted_cidrs_api
branch
from
f83970d
to
93e0306
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4500 +/- ##
=======================================
Coverage ? 65.50%
=======================================
Files ? 211
Lines ? 31858
Branches ? 0
=======================================
Hits ? 20870
Misses ? 9745
Partials ? 1243 ☔ View full report in Codecov by Sentry. |
rudrakhp
force-pushed
the
xff_trusted_cidrs_api
branch
4 times, most recently
from
e3454ff
to
8762bd5
Compare
|
Wanted to add docs after implementation is done but looks like a recent gen check is not allowing me to do that. |
zhaohuabing
reviewed
Oct 24, 2024
rudrakhp
force-pushed
the
xff_trusted_cidrs_api
branch
3 times, most recently
from
c9233b4
to
3c83553
Compare
zhaohuabing
reviewed
Oct 24, 2024
rudrakhp
force-pushed
the
xff_trusted_cidrs_api
branch
5 times, most recently
from
9ca481c
to
ecbd701
Compare
zhaohuabing
reviewed
Oct 25, 2024
zhaohuabing
reviewed
Oct 25, 2024
zhaohuabing
reviewed
Oct 25, 2024
zhaohuabing
reviewed
Oct 25, 2024
rudrakhp
force-pushed
the
xff_trusted_cidrs_api
branch
5 times, most recently
from
41d8653
to
7ab024c
Compare
rudrakhp
commented
Oct 25, 2024
zhaohuabing
reviewed
Oct 25, 2024
rudrakhp
force-pushed
the
xff_trusted_cidrs_api
branch
from
7ab024c
to
a57806b
Compare
rudrakhp
force-pushed
the
xff_trusted_cidrs_api
branch
2 times, most recently
from
c93d737
to
ef7b486
Compare
zhaohuabing
reviewed
Oct 28, 2024
zhaohuabing
previously approved these changes
Oct 28, 2024
Signed-off-by: Rudrakh Panigrahi <[email protected]>
rudrakhp
force-pushed
the
xff_trusted_cidrs_api
branch
from
ef7b486
to
067756f
Compare
|
Let's hold off on merging API and feature PRs until v1.2 is released to simplify cherry picking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
api: support setting trusted CIDRs
What this PR does / why we need it:
To configure Envoy API's xff_trusted_cidrs param.
Which issue(s) this PR fixes:
Ref #4489
Release Notes: Yes