-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incremental: support for linear and mux caches #459
incremental: support for linear and mux caches #459
Conversation
Signed-off-by: Sergey Matyukevich <[email protected]>
Signed-off-by: Sergey Matyukevich <[email protected]>
Signed-off-by: Sergey Matyukevich <[email protected]>
…into incremental-linear
Signed-off-by: Sergey Matyukevich <[email protected]>
Signed-off-by: Sergey Matyukevich <[email protected]>
Signed-off-by: Sergey Matyukevich <[email protected]>
@alecholmez I did some refactoring in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few questions here, if we're moving to fix up the snapshot API and revisit some of the old stuff, what can we do here to require the least amount of boilerplate to be added
…into incremental-linear
Signed-off-by: Sergey Matyukevich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things/nits. This is definitely starting to look good, thanks for bearing with me on the review process!
Co-authored-by: Alec Holmes <[email protected]> Signed-off-by: Sergey Matyukevich <[email protected]>
7bcd17a
to
4d5c8f5
Compare
Signed-off-by: Sergey Matyukevich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few more comments. I think we've nailed down the overall design just a few more nits on my part
…into incremental-linear
Signed-off-by: Sergey Matyukevich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some log nits, then I think we can merge this
Signed-off-by: Sergey Matyukevich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks for the time and effort on this
No description provided.