-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache: add default logger #483
Conversation
@snowp here's that default logger I promised, I pulled out the nil logger checks in the cache since we don't need them anymore. I used uber's zap logger since it maps nicely to what we setup and it's the fastest structured logger which we probably need for a system like this. If we don't want a defaulted logger I can just make this a no-op |
Signed-off-by: Alec Holmes <[email protected]>
Signed-off-by: Alec Holmes <[email protected]>
Signed-off-by: Alec Holmes <[email protected]>
Signed-off-by: alecholmez <[email protected]>
Signed-off-by: alecholmez <[email protected]>
@snowp should be good to go, default is just a noop that logs out nothing. This keeps current logging behavior |
@snowp can we merge this in before we cut a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Alec Holmes [email protected]