Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache: add default logger #483

Merged
merged 5 commits into from
Oct 13, 2021
Merged

cache: add default logger #483

merged 5 commits into from
Oct 13, 2021

Conversation

alecholmez
Copy link
Contributor

Signed-off-by: Alec Holmes [email protected]

@alecholmez
Copy link
Contributor Author

alecholmez commented Aug 3, 2021

@snowp here's that default logger I promised, I pulled out the nil logger checks in the cache since we don't need them anymore. I used uber's zap logger since it maps nicely to what we setup and it's the fastest structured logger which we probably need for a system like this.

If we don't want a defaulted logger I can just make this a no-op

@alecholmez alecholmez changed the title add default logger cache: add default logger Aug 9, 2021
pkg/log/default.go Outdated Show resolved Hide resolved
Signed-off-by: alecholmez <[email protected]>
@alecholmez
Copy link
Contributor Author

@snowp should be good to go, default is just a noop that logs out nothing. This keeps current logging behavior

@alecholmez
Copy link
Contributor Author

@snowp can we merge this in before we cut a v0.10? Just want to clean up the PRs

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alecholmez alecholmez merged commit 44c5b0d into main Oct 13, 2021
@alecholmez alecholmez deleted the defaults branch October 13, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants