cache: rework snapshot api #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeach
reviewed
Aug 5, 2021
alecholmez
force-pushed
the
snapshot_api
branch
from
24157fd
to
539646d
Compare
Signed-off-by: Alec Holmes <[email protected]>
alecholmez
force-pushed
the
snapshot_api
branch
from
286f127
to
6b2ded9
Compare
jpeach
reviewed
Aug 11, 2021
|
@jpeach ended up aliasing to string instead of creating a whole new type. Now a lot of the snapshot stuff asks for a |
jpeach
reviewed
Aug 11, 2021
Signed-off-by: Alec Holmes <[email protected]>
alecholmez
force-pushed
the
snapshot_api
branch
from
7fc46ac
to
3fcfef5
Compare
snowp
reviewed
Aug 17, 2021
Signed-off-by: Alec Holmes <[email protected]>
|
@snowp just pushed that last change. |
Signed-off-by: Alec Holmes <[email protected]>
|
@snowp can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reworks cache api so we no longer need to change function signatures when adding support for new xDS services