Apply 'go mod tidy' after API sync

[mmorel-35]

@phlax ,
I believe there is no go mod tidy applied after envoy synchronisation

[phlax]

might be a good idea to add it

the sync happens here

go-control-plane/ci/sync_envoy.sh

Line 74 in db0b36a

build_protos

[mmorel-35]

I couldn't test this, in codespaces, I have :

$ ENVOY_SRC_DIR=../envoy ci/sync_envoy.sh
Building go protos ...
ENVOY_SRCDIR=/workspaces/envoy
ENVOY_BUILD_TARGET=//source/exe:envoy-static
ENVOY_BUILD_ARCH=x86_64
BUILD_DIR not set - defaulting to ~/.cache/envoy-bazel

Bazel is not installed on codespaces machines maybe it is related

[phlax]

dont worry about testing it we can land and if there is an issue we can revert

the only question i have is what go version this is using - one way/another i think we want to make sure its pinned

[phlax]

trying to rem how i tested previously - maybe i copied the workflow to trigger on pr altho cant rem if that is allowed for prs to do

[mmorel-35]

I installed bazellisk on codespace, it's working better now

[mmorel-35]

@phlax ,
Shall there be a make go-mod-tidy target or use the already existing make clean instead of directly execute a go mod tidy ?

[phlax]

not sure - im kinda surprised this repo uses make tbh

iiuc you would mostly want to run tidy after changing deps so probs a standalone target - but i have limited go experience, so happy to defer to others with more knowledge of go workflows

[sunjayBhatia]

I think what you have here is sufficient, a new make target would be a bit verbose for just running go mod tidy and make clean isn't necessary, that seems more for a local dev environment where you may have old binaries etc lying around