Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use replace in examples/dyplomat and xdsmatcher modules #912

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mmorel-35
Copy link
Contributor

No description provided.

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Apr 1, 2024

@phlax , @sunjayBhatia,
vscode is showing warnings but ci doesn't scream. I don't see why

By the way, I believe that go mod tidy applied on the main module in sync_protos from sync_envoy.sh shall also be applied for every submodule in that case, WDYT ?

Copy link
Contributor

@valerian-roche valerian-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this

@phlax phlax merged commit 7ddbdf5 into envoyproxy:main Apr 2, 2024
5 checks passed
@mmorel-35 mmorel-35 deleted the replace branch April 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants