Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring api and service protos up-to-date with data-plane-api #68

Closed
lvijay opened this issue Sep 27, 2018 · 0 comments
Closed

bring api and service protos up-to-date with data-plane-api #68

lvijay opened this issue Sep 27, 2018 · 0 comments

Comments

@lvijay
Copy link
Contributor

lvijay commented Sep 27, 2018 •
edited
Loading

afaict the last update with the data-plane-api was #63, Jul 17.

Can we bring them up to date? I'm specifically interested in the work done in Envoy issue #3555 which was addressed in Envoy PR #4015.
lvijay pushed a commit to lvijay/java-control-plane that referenced this issue Sep 27, 2018
@vijay-lakshminarayanan
Update to latest version of data-plane-api protos
ce13fd5 
This version is up-to-date as of data-plan-api sha 512daa2.

Fixes envoyproxy#68.

Testing done:

    mvn verify

succeeds.
lvijay pushed a commit to lvijay/java-control-plane that referenced this issue Sep 27, 2018
@vijay-lakshminarayanan
Update to latest version of data-plane-api protos
89bff6e 
This version is up-to-date as of data-plan-api sha 512daa2.

Fixes envoyproxy#68.

Testing done:

    mvn verify

succeeds.

Signed-off-by: Vijay Lakshminarayanan <[email protected]>
@lvijay lvijay mentioned this issue Sep 27, 2018
Merged
@joeyb joeyb closed this as completed in #69 Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lvijay