-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade radix #137
Merged
+566
−463
Merged
Upgrade radix #137
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3e2049a
Upgrade radix.v2 to radix.v3 and refactor redis cache impl to use pip…
caitong93 a532854
Go generate mocks
caitong93 d02118b
Fix unit tests
caitong93 030544b
Add benchmark for DoLimit method
caitong93 373994a
Fix typo and update README
caitong93 44516ce
Add unit tests for redis client impl
caitong93 42a7b3e
Fix unit test, do not use 6379 for a fake redis server.
caitong93 9f32d70
Update testify to use assert.PanicsWithError
caitong93 81b4266
Check specific error in TestNewClientImpl
caitong93 b7dee4d
Add more cases in BenchmarkParallelDoLimit
caitong93 44686e9
Merge branch 'master' into upgrade-radix
679fd0f
Fix merge
caitong93 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be not related to your change.
But the description seems not right regarding
if this client is nil
. I think we need to specify it as at least a pointer, then we can determine whether it is nil or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an interface, should be OK for nil testing.