Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for x-ratelimit-reset header #182

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Add support for x-ratelimit-reset header #182

merged 3 commits into from
Oct 22, 2020

Commits on Oct 20, 2020

  1. Add support for x-ratelimit-reset header 

    Signed-off-by: Clara Andrew-Wani <[email protected]>
    @clarakosi
    clarakosi committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    589ea10 View commit details
    Browse the repository at this point in the history

  2. integration_test: Delete JSON tests from TestBasicConfigLegacy test 

    Removed a portion of the TestBasicConfigLegacy test because it used
JSON instead of GRPC to make the request. JSON defaults to the latest
GRPC message and uses latest version which does not test the legacy behavior

Signed-off-by: Clara Andrew-Wani <[email protected]>
    @clarakosi
    clarakosi committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    e766a05 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Address code review comments 

    * Factored UnitToDivider to a uitility package
* Modified CalculateReset to pass timesource in the constructor
* Modified tests to use new changes

Signed-off-by: Clara Andrew-Wani <[email protected]>
    @clarakosi
    clarakosi committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    adadb3e View commit details
    Browse the repository at this point in the history