-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailed_metric support for xds-config #465
Conversation
Signed-off-by: alekhya.kondapuram <[email protected]>
Hey @envoyproxy/ratelimit-maintainers |
bump :) |
@birdayz Though the PR is merged, currently awaiting the release of the new version of the go-control-plane repo. The latest version is from 4 weeks ago and doesn't have my changes yet. https://pkg.go.dev/github.com/envoyproxy/go-control-plane/ratelimit/config/ratelimit/v3 |
Thanks for the quick response. |
@birdayz Thank you for the suggestion. I used commit instead of tag now and converted this PR from draft to review. |
Signed-off-by: alekhya.kondapuram <[email protected]>
Signed-off-by: alekhya.kondapuram <[email protected]>
Signed-off-by: alekhya.kondapuram <[email protected]>
Other changes LGTM. |
Signed-off-by: alekhya.kondapuram <[email protected]>
@renuka-fernando Thank you for your review and approval. |
@envoyproxy/ratelimit-maintainers Could you please help merge this PR? Thank you. |
@mattklein123 @ysawa0 Can you please help merge this? |
Please check CI. Also, is this a breaking change? It's a little unclear to me. |
Signed-off-by: alekhya.kondapuram <[email protected]>
@mattklein123 Thank you for looking into this. It's not a breaking change, but this has dependency on the go-control-plane repo as we rely on rls_conf.pb.go file. This was merged a couple of weeks ago. Hence I kept this PR in draft until that was merged. Converted it to review after the other PR was merged. Regarding the CI, Looks like there was a pre-commit end-of-file failure for rls_conf_ds.proto. Pushed a new commit. Could you please try to re-run the checks when you have some bandwidth? Thank you. |
@mattklein123 Looks like all the checks are successful, could you please help merge this when you get some time? Thank you. |
@mattklein123 Thank you for your review and approval. |
[Please NOTE] This PR has to be merged only after receiving approval for the PR on the go-control-plane.