-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial integration of DogStatsD #585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I apologize for making a design comment on an already implemented PR but what if instead of continuing to build support for specific company / vendor formats we instead implemented vendor-neutral OTEL Metrics ? |
mattklein123
previously requested changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment otherwise LGTM.
including something called mogrifiers Signed-off-by: Josh Jaques <[email protected]>
Signed-off-by: Josh Jaques <[email protected]>
Signed-off-by: Josh Jaques <[email protected]>
Signed-off-by: Josh Jaques <[email protected]>
- handle out of bounds match in pattern handler - make it an error if both statsd sink are enabled - improve error wording - add more test cases Signed-off-by: Josh Jaques <[email protected]>
Signed-off-by: Josh Jaques <[email protected]>
ysawa0
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
godogstats
package is implemented to bridgelyft/gostats
with dogstatsd.There is a new statsd sink implemented which will output the stats using dogstatsd protocol over UDP which allows tags.
Thus, a new
mogrification
feature is also added which lets us mogrify the stat from internal metric names, into a different name + tags, similar to what is done in the prom-stats-exporter exampleNote: there is some runtime cost associated with mogrifying the metrics but it should be minimal due to the existing in memory flushing architecture.