fix(prometheus_sink): log errors and fallback to default metric mapper #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harpunius <[email protected]>
harpunius
force-pushed
the
prometheus-sink-mapper-default-handling
branch
from
088ab19
to
95d8cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently migrated from statsd-exporter to the prometheus sink, and couldn't make the mapping work, until I found that the path didn't match up. This error is not logged currently, which is the main motivation for this PR.
I then thought that it would be nicer to fallback to the default mapper instead of having no mapping at all. Happy to rollback the default handling and simply add the error logs instead.
TestPrometheusSinkMetricMapperDefaultHandlingis simply a test that would fail without these changes.