Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement global bans #853

Closed
stwalkerster opened this issue Sep 21, 2023 · 0 comments · Fixed by #854
Closed

Implement global bans #853

stwalkerster opened this issue Sep 21, 2023 · 0 comments · Fixed by #854
Assignees
Labels
schema changes This task requires database schema changes

Comments

@stwalkerster
Copy link
Member

  • Ban testing
  • Ban UI
  • Database changes
    • domain column nullable
    • check constraint on domain null == not a queue deferral
@stwalkerster stwalkerster converted this from a draft issue Sep 21, 2023
@stwalkerster stwalkerster self-assigned this Sep 21, 2023
@stwalkerster stwalkerster added the schema changes This task requires database schema changes label Sep 21, 2023
stwalkerster added a commit that referenced this issue Sep 21, 2023
Adds a "global" flag to the ban UI, though in practice this is just UI
sugar for a nullable domain column. If domain is null, then the ban
applies globally. If it's a domain ID, the ban applies in that domain
only.

Also adds a new ban type flag which is granted to tool roots only to
allow setting global bans.

Fixes #853
@stwalkerster stwalkerster moved this from To do to Completed/unpublished in Multi-project support Sep 21, 2023
@stwalkerster stwalkerster linked a pull request Sep 21, 2023 that will close this issue
@stwalkerster stwalkerster moved this from Completed/unpublished to In review in Multi-project support Sep 21, 2023
stwalkerster added a commit that referenced this issue Sep 22, 2023
Adds a "global" flag to the ban UI, though in practice this is just UI
sugar for a nullable domain column. If domain is null, then the ban
applies globally. If it's a domain ID, the ban applies in that domain
only.

Also adds a new ban type flag which is granted to tool roots only to
allow setting global bans.

Fixes #853
@github-project-automation github-project-automation bot moved this from In review to Done in Multi-project support Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema changes This task requires database schema changes
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant