-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for object property selector #110
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -261,6 +261,58 @@ describeWithDOM('mount', () => { | |
expect(() => wrapper.find('.foo .foo')).to.throw(Error); | ||
}); | ||
|
||
it('should support object property selectors', () => { | ||
const wrapper = mount( | ||
<div> | ||
<input data-test="ref" className="foo" type="text" /> | ||
<input data-test="ref" type="text"/> | ||
<button data-test="ref" prop={undefined} /> | ||
<span data-test="ref" prop={null} /> | ||
<div data-test="ref" prop={123} /> | ||
<input data-test="ref" prop={false} /> | ||
<a data-test="ref" prop /> | ||
</div> | ||
); | ||
expect(wrapper.find({ a: 1 })).to.have.length(0); | ||
expect(wrapper.find({ 'data-test': 'ref' })).to.have.length(7); | ||
expect(wrapper.find({ className: 'foo' })).to.have.length(1); | ||
expect(wrapper.find({ prop: undefined })).to.have.length(1); | ||
expect(wrapper.find({ prop: null })).to.have.length(1); | ||
expect(wrapper.find({ prop: 123 })).to.have.length(1); | ||
expect(wrapper.find({ prop: false })).to.have.length(1); | ||
expect(wrapper.find({ prop: true })).to.have.length(1); | ||
}); | ||
|
||
it('should support complex and nested object property selectors', () => { | ||
const testFunction = () => {}; | ||
const wrapper = mount( | ||
<div> | ||
<span more={[{ id: 1 }]} data-test="ref" prop onChange={testFunction} /> | ||
<a more={[{ id: 1 }]} data-test="ref" /> | ||
<div more={{ item: { id: 1 } }} data-test="ref" /> | ||
<input style={{ height: 20 }} data-test="ref" /> | ||
</div> | ||
); | ||
expect(wrapper.find({ 'data-test': 'ref' })).to.have.length(4); | ||
expect(wrapper.find({ more: { a: 1 } })).to.have.length(0); | ||
expect(wrapper.find({ more: [{ id: 1 }] })).to.have.length(2); | ||
expect(wrapper.find({ more: { item: { id: 1 } } })).to.have.length(1); | ||
expect(wrapper.find({ style: { height: 20 } })).to.have.length(1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @lelandrichardson This works now with |
||
expect(wrapper | ||
.find({ more: [{ id: 1 }], 'data-test': 'ref', prop: true, onChange: testFunction }) | ||
).to.have.length(1); | ||
}); | ||
|
||
it('should throw when given empty object, null, or an array', () => { | ||
const wrapper = mount( | ||
<div> | ||
<input className="foo" type="text" /> | ||
</div> | ||
); | ||
expect(() => wrapper.find({})).to.throw(Error); | ||
expect(() => wrapper.find([])).to.throw(Error); | ||
expect(() => wrapper.find(null)).to.throw(Error); | ||
}); | ||
}); | ||
|
||
describe('.findWhere(predicate)', () => { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it expect an array also, per the above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
array gets caught by the
typeof
is'object'
, then errors out therei can also update the verbiage on the object error if you would like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes i misread the wording. it doesn't support null, or an array, or an empty object - i read "empty" as applying to all three. perhaps reverse the list on line 141?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, updated