Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Get correct displayName from memoized components #2137

Merged
merged 2 commits into from
May 25, 2019
Merged

[fix] Get correct displayName from memoized components #2137

merged 2 commits into from
May 25, 2019

Conversation

gustavovnicius
Copy link
Contributor

@gustavovnicius gustavovnicius commented May 24, 2019 •
edited by ljharb
Loading

Fixes #2136

ljharb
ljharb reviewed May 24, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I’ve already got a fix prepared for this, tho.

ljharb
ljharb approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will bring in your test case tho, thanks :-)

@ljharb
[enzyme-adapter-react-16] [fix] ensure the correct displayName for `m…
acc6528 
…emo` components.

Expected results verified with the React Dev Tools.
@ljharb ljharb merged commit acc6528 into enzymejs:master May 25, 2019
ljharb added a commit that referenced this pull request May 26, 2019
@ljharb
[enzyme-adapter-react-16] v1.13.2
b6b639f 
 - [fix] ensure the correct displayName for `memo` components (#2137)
 - [fix] `mount`: wrap simulate() in ReactTestUtils.act() (#2135)
 - [fix] properly handle `memo`’s `areEquals` arg (#2128)
 - [dev deps] update `eslint-plugin-import`
 - [deps] update `semver`
@snyk-bot snyk-bot mentioned this pull request Oct 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
package: react adapter: 16 semver: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enzyme-adapter-react-16 render wrong displayName for decorated react-redux component
2 participants
@gustavovnicius @ljharb