Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: propagate Autorization header along with Api-Key header #135

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

adubovik
Copy link
Collaborator

OpenAI library sends Authorization header equal to Bearer ${API_KEY}, so that a request ends up having two auth-headers: Api-Key and Authorization.

The DIAL Core fails if the headers are inconsistent.

So we have to make them consistent in the header propagation logic.

@adubovik adubovik self-assigned this Jul 15, 2024
tests/header_propagation/client.py Dismissed Show dismissed Hide dismissed
tests/header_propagation/client.py Dismissed Show dismissed Hide dismissed
tests/header_propagation/client.py Dismissed Show dismissed Hide dismissed
tests/header_propagation/client.py Dismissed Show dismissed Hide dismissed
@adubovik adubovik merged commit 2e0e4dd into development Jul 16, 2024
12 checks passed
@adubovik adubovik deleted the feat/propagate-authorization-header branch July 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants