fix: handling client disconnect gracefully by propagating cancellation exception up to the chat completion handler #185
+265
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-romanov-o
previously approved these changes
Nov 18, 2024
tests/test_cancellation.py
Outdated
|
|
||
|
|
||
| @pytest.mark.parametrize("with_heartbeat", [True, False]) | ||
| async def test_cancellation(with_heartbeat: bool): |
There was a problem hiding this comment.
Please, extend this with the test:
1.Run chat completion
2.Inside of chat completion create nested tasks, that run forever
3.Cancel chat completion
4.Check that nested tasks are also canceled
There was a problem hiding this comment.
Fixed, added more tests
aidial_sdk/utils/_cancel_scope.py
Outdated
| async def __aenter__(self): | ||
| return self | ||
|
|
||
| async def __aexit__(self, et, exc, tb): |
There was a problem hiding this comment.
Let's use the same naming, that official PEP introduces:
async def __aexit__(self, exc_type, exc, tb):
...It's quite easy to confuse et with something else, then exception type.
adubovik
force-pushed
the
fix/propagate-cancellation-error
branch
from
c764571
to
4a62262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.