Skip to content

Commit

Permalink
[EPMDEDP-12267]: fix: Set default deploymentScript for codebase to he…
Browse files Browse the repository at this point in the history
…lm-chart

Let's be more agile and do not make this field mandatory, just not to break
backward API compatibility. As the next step we should be more restrictive
and set this field to enum with validation check

Signed-off-by: Sergiy Kulanov <[email protected]>
Change-Id: I300043b14db2d20c4389d6944fc19944a5eee30c
  • Loading branch information
SergK committed Jul 17, 2023
1 parent 2972121 commit 87a4711
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions api/v1/codebase_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ type CodebaseSpec struct {
JobProvisioning *string `json:"jobProvisioning"`

// +optional
// +kubebuilder:default:=helm-chart
DeploymentScript string `json:"deploymentScript,omitempty"`

Versioning Versioning `json:"versioning"`
Expand Down
1 change: 1 addition & 0 deletions config/crd/bases/v2.edp.epam.com_codebases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ spec:
description: Name of default branch.
type: string
deploymentScript:
default: helm-chart
type: string
description:
description: A short description of codebase.
Expand Down
1 change: 1 addition & 0 deletions deploy-templates/crds/v2.edp.epam.com_codebases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ spec:
description: Name of default branch.
type: string
deploymentScript:
default: helm-chart
type: string
description:
description: A short description of codebase.
Expand Down
2 changes: 2 additions & 0 deletions docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,8 @@ CodebaseSpec defines the desired state of Codebase.
<td>string</td>
<td>
<br/>
<br/>
<i>Default</i>: helm-chart<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down

0 comments on commit 87a4711

Please sign in to comment.