Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CodebaseImageStream to contain docker hub image #17

Closed
zmotso opened this issue Sep 28, 2023 · 0 comments
Closed

Allow CodebaseImageStream to contain docker hub image #17

zmotso opened this issue Sep 28, 2023 · 0 comments
Assignees
@zmotso

Comments

@zmotso
Copy link
Contributor

zmotso commented Sep 28, 2023

The Codebase operator currently creates CodebasImageStream with such image:
docker-registry URL(taken from EDPComponent)/current namespace/Codebase name.
We can't use such a pattern for the docker hub because instead of the current namespace, we need a docker hub profile name.
To support both approaches, we can remove the current namespace from the image name and move this namespace to the docker-registry URL (EDPComponent) for the previous logic.
@zmotso zmotso self-assigned this Sep 28, 2023
epmd-edp pushed a commit that referenced this issue Sep 28, 2023
@zmotso
feat: Allow CodebaseImageStream to contain docker hub image (#17)
ea1057e 
Removed the current namespace from the image name to support the docker hub(we can't use namespace as the profile name). To support the old approach, we can move this namespace to the docker-registry URL (EDPComponent).

Change-Id: I27a62a4a404fb464c079e14988d658fb25a6860a
@zmotso zmotso closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmotso zmotso

Labels
None yet
Projects
KubeRocketCI (EPAM Delivery Platform)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zmotso