Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard shortcut should not change current tool if cursor is over an atom #1826

Closed
vanoprenko opened this issue Nov 9, 2022 · 0 comments · Fixed by #1877
Closed

Keyboard shortcut should not change current tool if cursor is over an atom #1826

vanoprenko opened this issue Nov 9, 2022 · 0 comments · Fixed by #1877
Assignees
@KonstantinEpam23
Labels
feature request
Milestone
Release 2.7.0

Comments

@vanoprenko
Copy link
Collaborator

Currently when user uses a keyboard shortcut, this always changes current/selected tool, so that all further clicks on canvas will apply this tool (e.g. if 'F' is pressed, current tool will be set to Fluorine atom and applied on mouse clicks until another tool is selected via a button or a shortcut).

This logic should be changed in case mouse cursor is hovering over an atom. If keyboard shortcut is used in such a case, it should not change the current/selected tool. Instead corresponding tool should be applied once while keeping current tool unchanged. E.g. if user has single bond tool selected, puts mouse cursor over an atom and presses 'I', Iodine tool should be applied once but single bond tool to be kept selected and applied on further mouse clicks.
@vanoprenko vanoprenko added this to the Release 2.7.0 milestone Nov 9, 2022
KonstantinEpam23 pushed a commit that referenced this issue Nov 30, 2022
@KonstantinEpam
#1826: do not select a hotkey tool if we are hovering over an atom
0111473
KonstantinEpam23 pushed a commit that referenced this issue Nov 30, 2022
@KonstantinEpam
#1826: do not select a hotkey tool if we are hovering over an atom / …
eb97c36 
…eslint
@Nitvex Nitvex linked a pull request Nov 30, 2022 that will close this issue
#1826 dont select tools on hover #1877
Merged
KonstantinEpam23 pushed a commit that referenced this issue Nov 30, 2022
@KonstantinEpam
#1826: do not select a hotkey tool if we are hovering over an atom / …
ada362a 
…let -> const
KonstantinEpam23 pushed a commit that referenced this issue Nov 30, 2022
@KonstantinEpam
#1826: do not select a hotkey tool if we are hovering over an atom / …
db45c88 
…fix types for hotkeys.js
KonstantinEpam23 pushed a commit that referenced this issue Nov 30, 2022
@KonstantinEpam
#1826: do not select a hotkey tool if we are hovering over an atom / …
bd24f58 
…fix import error
KonstantinEpam23 pushed a commit that referenced this issue Dec 1, 2022
@KonstantinEpam
Merge branch 'master' into #1826-dont-select-tools-on-hover
ead65ef
KonstantinEpam23 added a commit that referenced this issue Dec 1, 2022
@KonstantinEpam23 @KonstantinEpam
#1826 dont select tools on hover (#1877)
d53a09f 
* #1826: do not select a hotkey tool if we are hovering over an atom

* #1826: do not select a hotkey tool if we are hovering over an atom / eslint

* #1826: do not select a hotkey tool if we are hovering over an atom / let -> const

* #1826: do not select a hotkey tool if we are hovering over an atom / fix types for hotkeys.js

* #1826: do not select a hotkey tool if we are hovering over an atom / fix import error

Co-authored-by: Konstantin Levin <[email protected]>
@St-Permiakov St-Permiakov mentioned this issue Jan 5, 2023
Merged
@Nitvex Nitvex added the rc.1 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KonstantinEpam23 KonstantinEpam23

Labels
feature request
Projects
None yet
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

#1826 dont select tools on hover epam/ketcher
4 participants
@vanoprenko @Nitvex @evgeniiFrolov1 @KonstantinEpam23