Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App crashes when template dialog is closed and reopened and there is text in the search filter #1973

Closed
KonstantinEpam23 opened this issue Dec 21, 2022 · 0 comments · Fixed by #1974
Closed

App crashes when template dialog is closed and reopened and there is text in the search filter #1973

KonstantinEpam23 opened this issue Dec 21, 2022 · 0 comments · Fixed by #1974
Assignees
@Nitvex
Labels
bug
Milestone
Release 2.7.0

Comments

@KonstantinEpam23
Copy link
Collaborator

KonstantinEpam23 commented Dec 21, 2022 •
edited
Loading

Steps to Reproduce

  1. Open template dialog
  2. Type something in the search filter bar
  3. Without selecting anything - close the template dialog
  4. Open template dialog again

Actual behavior
App crashes and an error is thrown in the console

Expected behavior
Closing the template dialog should not crash the app, even if there is text in the search filter

Ketcher version
v2.7.0
@KonstantinEpam23 KonstantinEpam23 added this to the Release 2.7.0 milestone Dec 21, 2022
@KonstantinEpam23 KonstantinEpam23 self-assigned this Dec 21, 2022
@Nitvex Nitvex assigned Nitvex and unassigned KonstantinEpam23 Dec 21, 2022
Nitvex added a commit that referenced this issue Dec 21, 2022
@Nitvex
#1973 – App crashes when template dialog is closed and there is text …
790e4f8 
…in the search filter
@Nitvex Nitvex mentioned this issue Dec 21, 2022
Merged
@Nitvex Nitvex linked a pull request Dec 21, 2022 that will close this issue
#1973 – App crashes when template dialog is closed and there is text in the search filter #1974
Merged
Nitvex added a commit that referenced this issue Dec 21, 2022
@Nitvex
#1973 – App crashes when template dialog is closed and there is text …
60b27f6 
…in the search filter (#1974)
Nitvex added a commit that referenced this issue Dec 21, 2022
@Nitvex
Backmerge: #1973 – App crashes when template dialog is closed and the…
cb7000b 
…re is text in the search filter (#1974)
Nitvex added a commit that referenced this issue Dec 21, 2022
@Nitvex
Backmerge: #1973 – App crashes when template dialog is closed and the…
c15d0b7 
…re is text in the search filter (#1974) (#1975)
@Nitvex Nitvex closed this as completed Dec 22, 2022
@KonstantinEpam23 KonstantinEpam23 changed the title App crashes when template dialog is closed and there is text in the search filter App crashes when template dialog is closed and reopened and there is text in the search filter Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug
Projects
None yet
Milestone
Release 2.7.0
2 participants
@Nitvex @KonstantinEpam23