Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: "Zoom" tool #2369

Closed
KsenMs opened this issue Mar 16, 2023 · 3 comments · Fixed by #3476
Closed

Macro: "Zoom" tool #2369

KsenMs opened this issue Mar 16, 2023 · 3 comments · Fixed by #3476
Assignees
@StarlaStarla
Labels
feature request Macromolecules [PE] Basic drawing operations
Milestone
Macromolecules Mi...

Comments

@KsenMs
Copy link
Collaborator

KsenMs commented Mar 16, 2023 •
edited
Loading

  1. There is a zoom button
  2. Zoom button has 3 options
  • zoom in
  • zoom out
  • 100%
  1. When user clicks to zoom in, system zooms in to the center of the current view (limits and step similar to ketcher)
  2. When user clicks to zoom out, system zooms out of the center of the current view (limits and step similar to ketcher)
  3. When user clicks 100% the system returns to 100% scale
@KsenMs KsenMs mentioned this issue Mar 31, 2023
Open
@KsenMs KsenMs changed the title "Zoom" tool - draft "Zoom" tool Apr 27, 2023
@KsenMs KsenMs removed the draft label Apr 27, 2023
@OlZhur OlZhur added this to the Polymer Editor MVP milestone Apr 28, 2023
Nitvex added a commit that referenced this issue Oct 10, 2023
@Nitvex
#2369 – added zoom tool
72b24c6
Nitvex added a commit that referenced this issue Oct 10, 2023
@Nitvex
#2369 – added zoom for monomers and bonds
4580925
Nitvex added a commit that referenced this issue Oct 10, 2023
@Nitvex
#2369 – added zoom for preview and selection
09006af
@rrodionov91 rrodionov91 assigned StarlaStarla and unassigned Nitvex Oct 10, 2023
@OlZhur OlZhur changed the title "Zoom" tool [Macro] "Zoom" tool Oct 16, 2023
StarlaStarla added a commit that referenced this issue Oct 20, 2023
@StarlaStarla
#2369 merge master
5920e4d
StarlaStarla added a commit that referenced this issue Oct 20, 2023
@StarlaStarla
#2369 add zoom menu and fix coordinates conversion
ca1a1aa
StarlaStarla added a commit that referenced this issue Oct 20, 2023
@StarlaStarla
#2369 add autotests
b3b35bb
StarlaStarla added a commit that referenced this issue Oct 20, 2023
@StarlaStarla
#2369 update tests
eeb9afc
StarlaStarla added a commit that referenced this issue Oct 20, 2023
@StarlaStarla
#2369 update tests
60eb411
@StarlaStarla StarlaStarla linked a pull request Oct 20, 2023 that will close this issue
#2369 - [Macro] "Zoom" tool #3476
Merged
9 tasks
@MartaWilliams
Copy link
Collaborator

Tested

StarlaStarla added a commit that referenced this issue Oct 26, 2023
@StarlaStarla
#2369 update rotation logic for attachment point
1633b31
@rrodionov91 rrodionov91 changed the title [Macro] "Zoom" tool Macro: "Zoom" tool Nov 2, 2023
StarlaStarla added a commit that referenced this issue Nov 2, 2023
@StarlaStarla
#2369 enhance & fix coordinates
c26ed3e
StarlaStarla added a commit that referenced this issue Nov 2, 2023
@StarlaStarla
#2369 fix unit test
071f7a9
StarlaStarla added a commit that referenced this issue Nov 3, 2023
@StarlaStarla
#2369 add shift for horizontal scroll
3445360
StarlaStarla added a commit that referenced this issue Nov 3, 2023
@StarlaStarla
#2369 fix tests
49adb66
StarlaStarla added a commit that referenced this issue Nov 7, 2023
@StarlaStarla
#2369 change data-testId to data-testid
95a5d9e
StarlaStarla added a commit that referenced this issue Nov 7, 2023
@StarlaStarla
#2369 change data-testId to data-testid
217195b
rrodionov91 added a commit that referenced this issue Nov 7, 2023
@StarlaStarla @rrodionov91
#2369 - [Macro] "Zoom" tool (#3476)
7962cc3 
* #2369 add zoom menu and fix coordinates conversion
* #2369 update rotation logic for attachment point
* #2369 enhance & fix coordinates
* #2360 add scrollbars for zoom
* #2369 add shift for horizontal scroll
* #2369 fix tests

---------

Co-authored-by: Roman Rodionov <[email protected]>
chgayane pushed a commit that referenced this issue Nov 8, 2023
@StarlaStarla @rrodionov91
#2369 - [Macro] "Zoom" tool (#3476)
031c60f 
* #2369 add zoom menu and fix coordinates conversion
* #2369 update rotation logic for attachment point
* #2369 enhance & fix coordinates
* #2360 add scrollbars for zoom
* #2369 add shift for horizontal scroll
* #2369 fix tests

---------

Co-authored-by: Roman Rodionov <[email protected]>
@Zhirnoff
Copy link
Collaborator

Manual tests added to the Automation table

@AnastasiyaPiatrovaKlu
Copy link
Collaborator

AnastasiyaPiatrovaKlu commented Nov 21, 2023 •
edited
Loading

Tested and passed.
'When a user clicks 100% the system returns to 100% scale' - no such a button '100%' in Macromoleculs mode yet.

Figma design:
https://www.figma.com/file/MZ28kJRelnXvBodXu54UKh/Macromolecules-(Polymer-Editor)-Playground?type=design&node-id=4467-98265&mode=design&t=G1VsmAPp7qk44nny-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
feature request Macromolecules [PE] Basic drawing operations
Projects
None yet
Milestone
Macromolecules Milestone 2
Development

Successfully merging a pull request may close this issue.

#2369 - [Macro] "Zoom" tool epam/ketcher
7 participants
@StarlaStarla @Nitvex @Zhirnoff @AnastasiyaPiatrovaKlu @MartaWilliams @KsenMs @OlZhur