Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: When pull bond away from monomer and press 'Escape', bond remains on canvas #3539

Closed
Zhirnoff opened this issue Nov 6, 2023 · 2 comments · Fixed by #3556
Closed

Macro: When pull bond away from monomer and press 'Escape', bond remains on canvas #3539

Zhirnoff opened this issue Nov 6, 2023 · 2 comments · Fixed by #3556
Assignees
@rrodionov91 @ivan-arkhipov-epam
Labels
bug Macromolecules Priority: Low
Milestone
Macromolecules Mi...

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Nov 6, 2023

Steps to Reproduce

  1. Switch to Macromolecule mode
  2. Add any monomer on canvas
  3. Select bond tool and start pull bond from monomer to any direction
  4. Press 'Escape' button

Actual behavior
When pull bond away from monomer and press 'Escape', bond remains on canvas

Expected behavior
When pull bond away from monomer and press 'Escape', bond disappears

Screenshots
.

2023-11-06_13h41_13.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.15.0-rc.4
@Zhirnoff Zhirnoff added the bug label Nov 6, 2023
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 2 milestone Nov 6, 2023
@ivan-arkhipov-epam ivan-arkhipov-epam self-assigned this Nov 7, 2023
@ivan-arkhipov-epam ivan-arkhipov-epam linked a pull request Nov 9, 2023 that will close this issue
Macro: #3539 – When pull bond away from monomer and press 'Escape', bond remains on canvas #3556
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Nov 9, 2023
@ivan-arkhipov-epam
Macro: #3539 – When pull bond away from monomer and press 'Escape', b…
7150de2 
…ond remains on canvas (#3556)

* Correct handling escape key when drawing a bond
@Zhirnoff
Copy link
Collaborator Author

Autotest written

@AnastasiyaPiatrovaKlu
Copy link
Collaborator

AnastasiyaPiatrovaKlu commented Nov 20, 2023 •
edited
Loading

Tested and passed.
Expected behavior equals Actual behavior.
When pulling the bond away from the monomer and pressing 'Escape', the bond disappears.

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

@ivan-arkhipov-epam ivan-arkhipov-epam

Labels
bug Macromolecules Priority: Low
Projects
Ketcher
Status: Done
Milestone
Macromolecules Milestone 2
5 participants
@rrodionov91 @AlexeyGirin @ivan-arkhipov-epam @Zhirnoff @AnastasiyaPiatrovaKlu