Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error appears in DevTool Console after call 'ketcher.setSettings' before templates initialization #3643

Closed
Zhirnoff opened this issue Dec 1, 2023 · 0 comments · Fixed by #3644 or #3645
Closed

Error appears in DevTool Console after call 'ketcher.setSettings' before templates initialization #3643

Zhirnoff opened this issue Dec 1, 2023 · 0 comments · Fixed by #3644 or #3645
Assignees
@Nitvex
Labels
bug Priority: High
Milestone
Ketcher 2.17.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 1, 2023 •
edited
Loading

Steps to Reproduce

  1. Call ketcher.setSettings api before templates library was initialized. F.e in Editor react component's 'onInit' property:
image

Actual behavior
Error appears in DevTool Console: The template library must be initialized before it can be reinitialized

Expected behavior
No errors in DevTool Console

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.17.0-rc.1

#186590730
@Zhirnoff Zhirnoff added this to the Ketcher 2.17.0-rc.2 milestone Dec 1, 2023
@rrodionov91 rrodionov91 changed the title Error appears in DevTool Console after call 'ketcher.setSettings' Error appears in DevTool Console after call 'ketcher.setSettings' before templates initialization Dec 1, 2023
rrodionov91 added a commit that referenced this issue Dec 1, 2023
@rrodionov91
#3643 - Error appears in DevTool Console after call 'ketcher.setSetti…
27c5b5d 
…ngs' before templates initialization

- added postponing of templates library reinitialization if it is not yet initialized
@rrodionov91 rrodionov91 linked a pull request Dec 1, 2023 that will close this issue
#3643 - Error appears in DevTool Console after call 'ketcher.setSettings' before templates initialization #3644
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Dec 1, 2023
@rrodionov91
#3643 - Error appears in DevTool Console after call 'ketcher.setSetti…
194d750 
…ngs' before templates initialization

- added postponing of templates library reinitialization if it is not yet initialized
@rrodionov91 rrodionov91 linked a pull request Dec 1, 2023 that will close this issue
Backmerge: #3643 - Error appears in DevTool Console after call 'ketcher.setSettings' before templates initialization #3645
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Dec 1, 2023
@rrodionov91
#3643 - Error appears in DevTool Console after call 'ketcher.setSetti…
31571e2 
…ngs' before templates initialization (#3644)

- added postponing of templates library reinitialization if it is not yet initialized

Co-authored-by: Roman Rodionov <[email protected]>
rrodionov91 added a commit that referenced this issue Dec 1, 2023
@rrodionov91
#3643 - Error appears in DevTool Console after call 'ketcher.setSetti…
65c1f53 
…ngs' before templates initialization (#3645)

- added postponing of templates library reinitialization if it is not yet initialized

Co-authored-by: Roman Rodionov <[email protected]>
@rrodionov91 rrodionov91 mentioned this issue Feb 26, 2024
Open
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug Priority: High
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.17.0-rc.2
2 participants
@Nitvex @Zhirnoff