Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Selected monomer does not appear above the others #3703

Closed
Zhirnoff opened this issue Dec 15, 2023 · 3 comments · Fixed by #3823
Closed

Macro: Selected monomer does not appear above the others #3703

Zhirnoff opened this issue Dec 15, 2023 · 3 comments · Fixed by #3823
Assignees
@Nitvex
Labels
bug Macromolecules Priority: Medium
Milestone
Ketcher 2.18.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Switch to Macro mode
  2. Add multiple monomers on top of each other
  3. Choose monomer that is under the others

Actual behavior
Selected monomer does not appear above the others

Expected behavior
Selected monomer appear above the others

Screenshots

2023-12-15_12h15_51.mp4

Desktop (please complete the following information):**

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.17.0-rc.2
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 4 milestone Dec 15, 2023
@rrodionov91 rrodionov91 assigned Nitvex and unassigned rrodionov91 and Nitvex Dec 26, 2023
@Konstantin1996
Copy link
Collaborator

Konstantin1996 commented Dec 27, 2023 •
edited
Loading

Hello, I tried to implement solution inside BaseMonomerRenderer.

I think we should use -> this.canvasWrapper.select('.rootElement').raise(); method. But we should trigger it only once.
Seems we need to call it during click and not inside BaseMonomerRenderer.ts.

Check draft PR here:
https://github.com/epam/ketcher/pull/3814/files

Here is the video how it works currently

example.mov

@Nitvex Nitvex self-assigned this Dec 29, 2023
Nitvex added a commit that referenced this issue Dec 29, 2023
@Nitvex
Macro: #3703 – Selected monomer does not appear above the others
5dcdbf6
@Nitvex Nitvex mentioned this issue Dec 29, 2023
Merged
9 tasks
Nitvex added a commit that referenced this issue Dec 29, 2023
@Nitvex
Macro: #3703 – Selected monomer does not appear above the others
03becd2
Nitvex added a commit that referenced this issue Jan 2, 2024
@Nitvex
#3703 – fixed CI tests
5078752
Nitvex added a commit that referenced this issue Jan 3, 2024
@Nitvex
#3703 – added render complete notification
02d323a
Nitvex added a commit that referenced this issue Jan 3, 2024
@Nitvex
#3703 – added render complete notification
094baa5
Nitvex added a commit that referenced this issue Jan 4, 2024
@Nitvex
Macro: #3703 – Selected monomer does not appear above the others (#3823)
a71249e 
* Macro: #3703 – Selected monomer does not appear above the others

* #3703 – fixed CI tests

* #3703 – added render complete notification
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Jan 4, 2024

Tests added to automation table.

@Zhirnoff
Copy link
Collaborator Author

Tested. No comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug Macromolecules Priority: Medium
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
Development

Successfully merging a pull request may close this issue.

Macro: #3703 – Selected monomer does not appear above the others epam/ketcher
6 participants
@rrodionov91 @AlexeyGirin @Konstantin1996 @Nitvex @Zhirnoff @OlZhur