Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When deleting part of a structure using a hotkey Del, and preview of structure is under mouse cursor, an error occurs. #3918

Closed
Zhirnoff opened this issue Jan 17, 2024 · 2 comments · Fixed by #4141 or #4147
Closed

When deleting part of a structure using a hotkey Del, and preview of structure is under mouse cursor, an error occurs. #3918

Zhirnoff opened this issue Jan 17, 2024 · 2 comments · Fixed by #4141 or #4147
Assignees
@rrodionov91
Labels
bug Priority: High
Milestone
Ketcher 2.19.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add several Benzene rings on canvas
  3. Hover mouse with structure preview over any atom or bond and press Del hotkey.
  4. Look at DevTool Console

Actual behavior
When deleting part of a structure using a hotkey Del, and preview of structure is under mouse cursor, an error occurs.

Expected behavior
Part of structure deleted. No errors in DevTool Console.

Screenshots

2024-01-17_14h58_34.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.18.0-rc.1]
@Zhirnoff Zhirnoff added this to the Ketcher 2.18.0-rc.3 milestone Jan 17, 2024
@Zhirnoff
Copy link
Collaborator Author

Test automated.

rrodionov91 added a commit that referenced this issue Feb 23, 2024
@rrodionov91
#3918 - When deleting part of a structure using a hotkey Del, and pre…
572990f 
…view of structure is under mouse cursor, an error occurs.

- added template connected preview hiding before erase by hotkey
@rrodionov91 rrodionov91 linked a pull request Feb 23, 2024 that will close this issue
#3918 - When deleting part of a structure using a hotkey Del, and preview of structure is under mouse cursor, an error occurs. #4141
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 23, 2024
@rrodionov91
#3918 - When deleting part of a structure using a hotkey Del, and pre…
5f30345 
…view of structure is under mouse cursor, an error occurs. (#4141)

- added template connected preview hiding before erase by hotkey
- fixed test

---------

Co-authored-by: Roman Rodionov <[email protected]>
rrodionov91 added a commit that referenced this issue Feb 23, 2024
@rrodionov91
#3918 - When deleting part of a structure using a hotkey Del, and pre…
2e051d8 
…view of structure is under mouse cursor, an error occurs.

- added template connected preview hiding before erase by hotkey
@rrodionov91 rrodionov91 linked a pull request Feb 23, 2024 that will close this issue
Backmerge: #3918 - When deleting part of a structure using a hotkey Del, and preview of structure is under mouse cursor, an error occurs. #4147
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 26, 2024
@rrodionov91
Backmerge: #3918 - When deleting part of a structure using a hotkey D…
dd42271 
…el, and preview of structure is under mouse cursor, an error occurs. (#4147)

- added template connected preview hiding before erase by hotkey
- fixed test

---------

Co-authored-by: Roman Rodionov <[email protected]>
@Zhirnoff
Copy link
Collaborator Author

Tested. Fixed.

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.19.0-rc.2
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff