Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design implementation is different from the reference design #4008

Closed
AlexeyGirin opened this issue Feb 1, 2024 · 1 comment · Fixed by #4060 or #4076
Closed

Design implementation is different from the reference design #4008

AlexeyGirin opened this issue Feb 1, 2024 · 1 comment · Fixed by #4060 or #4076
Assignees
@captain2b
Labels
bug Priority: Low query features phase II
Milestone
Ketcher 2.18.0-rc.6

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Feb 1, 2024 •
edited
Loading

Steps to Reproduce

  1. Click Open... button (Ctrl+O)
  2. Select open from file
  3. Select file: ItShowsMDLDrawObjects.pptx
  4. Click Open

Actual behavior
image

Expected behavior

  1. Grey color around structure list is darker than at reference design
  2. Corner should be rounded in case of scroll bar presence
  3. Divider line is missing at the bottom
  4. "Open structure" label should be at 20% taller than "File...", "Select structure" and Open labels
  5. Molecule surrounded line should be thinner

image

Environment details:
@AlexeyGirin AlexeyGirin assigned captain2b and Nitvex and unassigned Nitvex Feb 1, 2024
@AlexeyGirin AlexeyGirin mentioned this issue Feb 2, 2024
Closed
12 tasks
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.18.0-rc.5 milestone Feb 5, 2024
captain2b added a commit that referenced this issue Feb 8, 2024
@captain2b
#4008 Design implementation is different from the reference design fi…
efedeaf 
…x styles
@captain2b captain2b linked a pull request Feb 8, 2024 that will close this issue
4008 design implementation is different from the reference design #4060
Merged
9 tasks
captain2b added a commit that referenced this issue Feb 12, 2024
@captain2b
#4008 Design implementation is different from the reference design fi…
1951dde 
…x styles
captain2b added a commit that referenced this issue Feb 12, 2024
@captain2b
Backmerge: #4008 Design implementation is different from the referenc…
dfe1583 
…e design fix styles
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
Ketcher Version 2.18.0-rc.5 Build at 2024-02-13; 10:27:16
Indigo Toolkit Version 1.18.0-rc.6.3-gdb6a7f5e-wasm32-wasm-clang-12.0.0

@rrodionov91 rrodionov91 linked a pull request Feb 13, 2024 that will close this issue
Backmerge: 4008 design implementation is different from the reference design #4076
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@captain2b captain2b

Labels
bug Priority: Low query features phase II
Projects
None yet
Milestone
Ketcher 2.18.0-rc.6
4 participants
@captain2b @rrodionov91 @AlexeyGirin @Nitvex