Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the Sequence mode, when selecting elements on the canvas, the total number of elements is not displayed in the Right-click menu #4636

Closed
ViktoriaTkacheva opened this issue May 16, 2024 · 1 comment · Fixed by #4808
Closed

In the Sequence mode, when selecting elements on the canvas, the total number of elements is not displayed in the Right-click menu #4636

ViktoriaTkacheva opened this issue May 16, 2024 · 1 comment · Fixed by #4808
Assignees
@Guch1g0v
Labels
bug Macromolecules Priority: Medium Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.23.0-rc.1

Comments

@ViktoriaTkacheva
Copy link
Collaborator

Steps to Reproduce

  1. Switch to the Macro mode
  2. Add this structure to the canvas
    image
  3. Switch to the Sequence mode
    image
  4. Select the entire sequence and Right-click on it

Actual behavior
In the Right-click menu, the total number of nucleotides is displayed
image

Expected behavior
In the Right-click menu, the total number of elements is displayed
image

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (124.0.6367.201 ) x64

Ketcher version 2.21.0-rc.2, Build at 2024-05-16; 12:32:02

Issue found while testing #3824
@ViktoriaTkacheva ViktoriaTkacheva added this to the Ketcher 2.23.0-rc.1 milestone May 16, 2024
@Guch1g0v Guch1g0v self-assigned this Jun 5, 2024
Guch1g0v added a commit that referenced this issue Jun 6, 2024
@Guch1g0v
#4636 - In the Sequence mode, when selecting elements on the canvas, …
7345857 
…the total number of elements is not displayed in the Right-click menu
@Guch1g0v Guch1g0v linked a pull request Jun 6, 2024 that will close this issue
#4636 - In the Sequence mode, when selecting elements on the canvas, the total number of elements is not displayed in the Right-click menu #4808
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jun 10, 2024
@Guch1g0v
#4636 - In the Sequence mode, when selecting elements on the canvas, …
ffd4710 
…the total number of elements is not displayed in the Right-click menu (#4808)

- added isNucleotideNucleosideOrPhosphate function
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jul 3, 2024

Tested. Bug fixed.
2024-07-03_09h49_07

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.1]
Indigo version
[Version 1.22.0-rc.1]

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
bug Macromolecules Priority: Medium Sequence mode Bucket: Sequence mode related issues
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.23.0-rc.1
3 participants
@Zhirnoff @Guch1g0v @ViktoriaTkacheva