Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect bond alignment to tBu S-group #4693

Closed
Zhirnoff opened this issue May 27, 2024 · 1 comment · Fixed by #4733 or #4741
Closed

Incorrect bond alignment to tBu S-group #4693

Zhirnoff opened this issue May 27, 2024 · 1 comment · Fixed by #4733 or #4741
Assignees
@rrodionov91
Labels
bug Customer Feedback Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High
Milestone
Ketcher 2.22.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented May 27, 2024 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher Micro mode
  2. Create or load a molecule structure containing a tBu group inorganic.zip
  3. Observe bond alignment to the tBu group.

Actual behavior
Ketcher displays connections to collapsed S-Groups unevenly if there is no R group attachment point. Bonds connected to the tBu group are not displayed correctly, resulting in misaligned and skewed connections. This misalignment affects the visual representation and clarity of molecular structure.

Expected behavior
Bonds connected to the tBu group should be straight and correctly aligned to ensure accurate and clear depiction of molecular structure.

Video

2024-05-27_12h17_27.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.21.0-rc.2]

#187667266
@Zhirnoff Zhirnoff added bug Priority: High Customer Feedback Micromolecules canvas Bucket: Micromolecules canvas related issues labels May 27, 2024
rrodionov91 added a commit that referenced this issue Jun 3, 2024
@rrodionov91
#4693 - Incorrect bond alignment to tBu S-group
321fcf8 
- fixed position calculation for external bonds to sgroups without attachment points
@rrodionov91 rrodionov91 linked a pull request Jun 3, 2024 that will close this issue
Backmerge: #4693 - Incorrect bond alignment to tBu S-group #4733
Merged
9 tasks
@rrodionov91 rrodionov91 self-assigned this Jun 3, 2024
rrodionov91 added a commit that referenced this issue Jun 4, 2024
@rrodionov91
#4693 - Incorrect bond alignment to tBu S-group
c6b256f 
- fixed position calculation for external bonds to sgroups without attachment points
@rrodionov91 rrodionov91 linked a pull request Jun 4, 2024 that will close this issue
#4693 - Incorrect bond alignment to tBu S-group #4741
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 4, 2024
@rrodionov91
#4693 - Incorrect bond alignment to tBu S-group (#4741)
d00edaa 
- fixed position calculation for external bonds to sgroups without attachment points
rrodionov91 added a commit that referenced this issue Jun 4, 2024
@rrodionov91
#4693 - Incorrect bond alignment to tBu S-group (#4733)
dc33e5d 
- fixed position calculation for external bonds to sgroups without attachment points
@Zhirnoff
Copy link
Collaborator Author

2024-06-10_16h10_10

Tested. Bug fixed.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.3]
Indigo version
[Version 1.21.0-rc.1]

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Customer Feedback Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.22.0-rc.3
2 participants
@rrodionov91 @Zhirnoff