Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete of nucleoside symbol turns another nucleoside to nucleotide #4726

Closed
AlexeyGirin opened this issue Jun 1, 2024 · 1 comment · Fixed by #4789 or #4807
Closed

Delete of nucleoside symbol turns another nucleoside to nucleotide #4726

AlexeyGirin opened this issue Jun 1, 2024 · 1 comment · Fixed by #4789 or #4807
Assignees
@rrodionov91
Labels
bug Priority: Medium Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.22.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 1, 2024 •
edited
Loading

This is follow up of #4399 , confirmed by @olganaz
Steps to Reproduce

  1. Switch to Macro
  2. Load from file: Delete of nucleoside symbol turns another nucleoside to nucleotide.zip
  3. Switch to Sequence mode
    image
  4. Edit sequence and remove one of nucleoside
    image

Actual behavior
System turns nucleoside from the left to nucleotide
image

Expected behavior
All nucleosides remain in place
image

Versions:
Windows 10
Chrome Version 125.0.6422.113 (Official Build) (64-bit)
Ketcher Version 2.21.0-rc.2 Build at 2024-05-31; 10:48:44
Indigo Toolkit Version 1.21.0-dev.5.2-g994bdab98-x86_64-linux-gnu-11.2.1
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.22.0-rc.2 milestone Jun 1, 2024
@AlexeyGirin AlexeyGirin added the Sequence mode Bucket: Sequence mode related issues label Jun 1, 2024
@rrodionov91 rrodionov91 self-assigned this Jun 6, 2024
rrodionov91 added a commit that referenced this issue Jun 6, 2024
@rrodionov91
#4726 - Delete of nucleoside symbol turns another nucleoside to nucle…
bc22818 
…otide

- skip phosphate add/delete logic for middle/beginning of chain
@rrodionov91 rrodionov91 linked a pull request Jun 6, 2024 that will close this issue
#4726 - Delete of nucleoside symbol turns another nucleoside to nucleotide #4789
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 6, 2024
@rrodionov91
#4726 - Delete of nucleoside symbol turns another nucleoside to nucle…
2223250 
…otide

- skip phosphate add/delete logic for middle/beginning of chain
@rrodionov91 rrodionov91 linked a pull request Jun 6, 2024 that will close this issue
Backmerge: #4726 - Delete of nucleoside symbol turns another nucleoside to nucleotide #4807
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 7, 2024
@rrodionov91
#4726 - Delete of nucleoside symbol turns another nucleoside to nucle…
0c90461 
…otide (#4789)

- skip phosphate add/delete logic for middle/beginning of chain
- restricted entering symbols before phosphate
- updated screenshot
rrodionov91 added a commit that referenced this issue Jun 7, 2024
@rrodionov91
Backmerge: #4726 - Delete of nucleoside symbol turns another nucleosi…
14b6018 
…de to nucleotide (#4807)

- skip phosphate add/delete logic for middle/beginning of chain
- restricted entering symbols before phosphate
- updated screenshot
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.3 Build at 2024-06-10; 12:34:49
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: Medium Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.22.0-rc.3
2 participants
@rrodionov91 @AlexeyGirin