Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to create forbidden RNA preset #4763

Closed
AlexeyGirin opened this issue Jun 5, 2024 · 2 comments · Fixed by #4865
Closed

It is possible to create forbidden RNA preset #4763

AlexeyGirin opened this issue Jun 5, 2024 · 2 comments · Fixed by #4865
Assignees
Labels
bug Priority: Medium RNA Builder Bucket: RNA builder related issues

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 5, 2024

Steps to Reproduce

  1. Open RNA builder
  2. Click New Preset button
  3. Select Phosphate (P in my case)
  4. Select Base (A in my case)
  5. Select 3SS6 sugar
    image
  6. Press Add to Presets button

Actual behavior
Preset is created
image

Expected behavior
Corresponding error should be shown in a pop-up error box and 'Save'/'Add to presets' button should be disabled
Since 3SS6 sugar don't have R3 attachment point RNA preset is forbidden due to requirements:

Sugar without R3 connection point cannot make this nucleotide
If user validation rule is violated corresponding error should be shown in a pop-up error box and 'Save'/'Add to presets' button
should be disabled

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #3816

@DmitriiP-EPAM
Copy link
Collaborator

@AlexeyGirin believes that the problem may concern not only sugars, but also RNA bases and phosphates, however, such cases cannot be verified due to the fact that there is no phosphate without an R1 bond and there is no RNA base without an R1 bond.

I believe that at the code level the problem is due to an incorrect state update that selectGroupItemValidations receives.

vitaepam added a commit that referenced this issue Jun 25, 2024
vitaepam added a commit that referenced this issue Jul 3, 2024
vitaepam added a commit that referenced this issue Jul 3, 2024
NataliaLoginova pushed a commit that referenced this issue Jul 5, 2024
* #4763 - Add validations to Accordion action

* #4763 - Update playwright tests

* #4763 - Updates after review

* #4763 - Fix TS
accmeboot pushed a commit that referenced this issue Jul 5, 2024
* #4763 - Add validations to Accordion action

* #4763 - Update playwright tests

* #4763 - Updates after review

* #4763 - Fix TS
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-25; 05:30:25
  • Indigo Toolkit Version 1.23.0-dev.1.14-g284c33a1-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.73 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Priority: Medium RNA Builder Bucket: RNA builder related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants